Skip to content

add JWT signing and redirect for login flow #6129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

add JWT signing and redirect for login flow #6129

merged 1 commit into from
Jan 31, 2025

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 31, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the authentication and API request handling in the apps/login application. It introduces JWT verification, updates API routes, and modifies the login page structure to improve user experience.

Detailed summary

  • Deleted route.saltyapps/login/next.config.ts.
  • Updated API route from /api/request to /api/:path*.
  • Added JWT verification in apps/login/src/app/api/user/route.ts.
  • Introduced signJWT and verifyJWT functions in apps/login/src/app/authorization/jwt.ts.
  • Refactored the login page to use LoginPageInner component.
  • Enhanced twl.js to handle JWT and user state.
  • Updated twl.min.js to manage login/logout states.
  • Added HTML structure for a test page in apps/login/test/script-test.html.
  • Added SVG logo in apps/login/public/logo.svg.
  • Improved session key handling in various components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 9:23pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 9:23pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 9:23pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 9:23pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 9:23pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a0d1c82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 31, 2025 01:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 31, 2025 01:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 31, 2025 01:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 31, 2025 01:54 Inactive
@jnsdls jnsdls marked this pull request as ready for review January 31, 2025 01:54
@jnsdls jnsdls requested review from a team as code owners January 31, 2025 01:54
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Jan 31, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.89%. Comparing base (2405456) to head (193e8c3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6129   +/-   ##
=======================================
  Coverage   56.89%   56.89%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5184     5184           
=======================================
  Hits        36353    36353           
  Misses      26815    26815           
  Partials      728      728
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2405456
packages 55.08% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 706 ms (+36.25% 🔺) 1.7 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 1.1 s (-25.55% 🔽) 3.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 167 ms (+197.27% 🔺) 279 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 16 ms (+11.64% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 130 ms (+19.8% 🔺) 516 ms

@jnsdls jnsdls force-pushed the add_JWT_signing_and_redirect_for_login_flow branch from bacb489 to 530712c Compare January 31, 2025 03:14
graphite-app[bot]
graphite-app bot reviewed Jan 31, 2025
View reviewed changes
@jnsdls jnsdls force-pushed the add_JWT_signing_and_redirect_for_login_flow branch from 530712c to 82e8224 Compare January 31, 2025 03:20
@jnsdls jnsdls force-pushed the add_JWT_signing_and_redirect_for_login_flow branch from 82e8224 to e53837d Compare January 31, 2025 20:47
@jnsdls jnsdls force-pushed the add_JWT_signing_and_redirect_for_login_flow branch from e53837d to 9db0143 Compare January 31, 2025 21:06
@jnsdls jnsdls force-pushed the add_JWT_signing_and_redirect_for_login_flow branch from 9db0143 to a0d1c82 Compare January 31, 2025 21:12
graphite-app[bot]
graphite-app bot reviewed Jan 31, 2025
View reviewed changes
@jnsdls jnsdls force-pushed the add_JWT_signing_and_redirect_for_login_flow branch from a0d1c82 to 193e8c3 Compare January 31, 2025 21:20
@jnsdls jnsdls merged commit 5f7c726 into main Jan 31, 2025
32 of 33 checks passed
@jnsdls jnsdls deleted the add_JWT_signing_and_redirect_for_login_flow branch January 31, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

@jnsdls jnsdls

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnsdls